Conversation
Contributor
|
Found 6 unused localization strings in the codebase. Click to see detailsTo remove them, run the |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the app’s loading/standby presentation to use a bundled animated Home Assistant logo SVG rendered via a transparent WKWebView, and refreshes the launch splash/LaunchScreen OHF wordmark asset sizing.
Changes:
- Replace the standby loading presentation with an animated SVG overlay (new
AnimatedSVGView+AnimatedSVGWebViewCacheand integration inHomeAssistantStandByView). - Update launch screen / splash overlay to use the
ohf-inlineasset and new sizing. - Remove legacy Lottie JSON resources (home / ha-loading / error) and update SwiftPM
Package.resolvedhash.
Reviewed changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/App/Resources/Lottie Files/home.json | Removes legacy Lottie “home” animation resource. |
| Sources/App/Resources/Lottie Files/ha-loading.json | Removes legacy Lottie loading animation resource. |
| Sources/App/Resources/Lottie Files/error.json | Removes legacy Lottie error animation resource. |
| Sources/App/Resources/home-assistant-logo-loading.svg | Adds the new animated SVG used for the loading logo. |
| Sources/App/Resources/Base.lproj/LaunchScreen.storyboard | Switches launch screen wordmark image reference and adjusts sizing. |
| Sources/App/Resources/Assets.xcassets/LaunchScreen/ohf-inline.imageset/OHF-lockup-inline-monochrome-on-light.svg | Adds new OHF inline lockup (light). |
| Sources/App/Resources/Assets.xcassets/LaunchScreen/ohf-inline.imageset/OHF-lockup-inline-monochrome-on-dark.svg | Adds new OHF inline lockup (dark). |
| Sources/App/Resources/Assets.xcassets/LaunchScreen/ohf-inline.imageset/Contents.json | Adds asset catalog metadata for the new OHF inline lockup. |
| Sources/App/Frontend/WebView/Views/HomeAssistantStandByView.swift | Integrates the animated SVG loading logo and refactors layout. |
| Sources/App/Frontend/WebView/Views/AnimatedSVGWebViewCache.swift | Adds a cache/preload layer for the animated SVG WKWebView. |
| Sources/App/Frontend/WebView/Views/AnimatedSVGView.swift | Adds the SwiftUI UIViewRepresentable wrapper for rendering the SVG. |
| Sources/App/Container/LaunchSplash/LaunchSplashOverlayView.swift | Updates splash overlay to use ohf-inline and the new frame size. |
| Sources/App/AppDelegate.swift | Preloads the animated SVG web view at launch. |
| HomeAssistant.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved | Updates SwiftPM resolution metadata hash. |
Comments suppressed due to low confidence (1)
Sources/App/Frontend/WebView/Views/AnimatedSVGWebViewCache.swift:41
- The
WKWebViewhere is only used to render a bundled SVG. Using a defaultWKWebViewConfiguration()keeps JavaScript and a persistent data store enabled, which is unnecessary and increases attack surface / potential disk writes. Prefer a hardened configuration (disable JS if possible and use a non-persistent data store).
private static func makeWebView() -> WKWebView {
let webView = WKWebView(frame: .zero, configuration: WKWebViewConfiguration())
webView.isOpaque = false
webView.backgroundColor = .clear
webView.scrollView.backgroundColor = .clear
…aunch Hand out the warm WKWebView only while it is unattached, creating a fresh loaded instance when it is already parented (multi-window scenes). Skip the launch-time preload on background location launches where the stand-by view is not shown.
Adjust logo (120) and OHF logo (height 25) sizes and mirror the new caption in the SwiftUI launch splash overlay.
Member
Author
|
Update with new ohf logo and ha logo size Screen.Recording.iPhone.17.Pro.07-23-2026.at.11.12.54.mp4 |
bgoncal
changed the title
bgoncal
marked this pull request as ready for review
July 24, 2026 02:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Policy
Select exactly one option that describes AI usage in this contribution:
Summary
Use animated HA logo SVG for loading screen.
Screenshots
Screen.Recording.2026-07-23.at.09.01.48.mov
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes