[pull] master from dart-lang:master#365
Merged
pull[bot] merged 6 commits intohttpsgithu:masterfrom May 27, 2021
Merged
Conversation
The implementation of const map literals is based on linear lookups in an array containing key/value pairs instead of a hash table. Bug: #45908 Golem CL: https://chrome-internal-review.googlesource.com/c/golem/+/3852562 Change-Id: If0a980339ee1342c41f9388e0bd7b3615a4ef4e3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200188 Commit-Queue: Daco Harkes <dacoharkes@google.com> Reviewed-by: Jonas Termansen <sortie@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
Change-Id: I6d95247fa088dba2f887e799c1cac6acd8456402 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201403 Reviewed-by: Dmitry Stefantsov <dmitryas@google.com> Commit-Queue: Johnni Winther <johnniwinther@google.com>
Change-Id: I69c7d0daf01dca4b84dfc84286d1bb2fa067a4a5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201480 Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Erik Ernst <eernst@google.com>
Bug: #46159 Change-Id: I2d628eb803e6b29c40ddb666e496f8fc98727960 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201560 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
…mplemented' ``` Crash when compiling null, at character offset null: Not implemented #0 TypeBuilderComputer.visitInvalidType (package:front_end/src/fasta/kernel/type_builder_computer.dart:42:5) #1 InvalidType.accept (package:kernel/ast.dart:10619:42) #2 TypeBuilderComputer.visitInterfaceType (package:front_end/src/fasta/kernel/type_builder_computer.dart:102:43) #3 InterfaceType.accept (package:kernel/ast.dart:10896:42) #4 DillLoader.computeTypeBuilder (package:front_end/src/fasta/dill/dill_loader.dart:117:17) #5 computeTypeBuilder (package:front_end/src/fasta/dill/dill_class_builder.dart:188:24) #6 DillClassBuilder.interfaceBuilders (package:front_end/src/fasta/dill/dill_class_builder.dart:156:21) #7 ClassHierarchyNodeBuilder.build (package:front_end/src/fasta/kernel/class_hierarchy_builder.dart:1490:39) #8 ClassHierarchyBuilder.getNodeFromClassBuilder (package:front_end/src/fasta/kernel/class_hierarchy_builder.dart:603:10) #9 ClassHierarchyBuilder.getNodeFromTypeBuilder (package:front_end/src/fasta/kernel/class_hierarchy_builder.dart:608:33) #10 ClassHierarchyNodeBuilder.build (package:front_end/src/fasta/kernel/class_hierarchy_builder.dart:1524:25) #11 ClassHierarchyBuilder.build (package:front_end/src/fasta/kernel/class_hierarchy_builder.dart:742:14) #12 SourceLoader.buildClassHierarchy (package:front_end/src/fasta/source/source_loader.dart:1213:46) #13 KernelTarget.buildOutlines.<anonymous closure> (package:front_end/src/fasta/kernel/kernel_target.dart:332:14) ``` Bug: #46160 Change-Id: Ic9198da47dde1a9c1653bcfa98c55e738ca93e64 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201561 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
``` Crash when compiling null, at character offset null: RangeError (index): Invalid value: Valid value range is empty: 1 #0 List.[] (dart:core-patch/growable_array.dart:254:60) #1 Class.superclassConstraints (package:kernel/ast.dart:1090:73) #2 ClassBuilderImpl.checkMixinApplication (package:front_end/src/fasta/builder/class_builder.dart:801:51) #3 SourceLoader.checkMixins (package:front_end/src/fasta/source/source_loader.dart:1165:19) #4 KernelTarget.buildOutlines.<anonymous closure> (package:front_end/src/fasta/kernel/kernel_target.dart:339:14) <asynchronous suspension> #5 withCrashReporting (package:front_end/src/fasta/crash.dart:121:12) <asynchronous suspension> #6 Outline.run.<anonymous closure> (file:///usr/local/google/home/jensj/code/dart-sdk/sdk/pkg/front_end/test/fasta/testing/suite.dart:1850:21) <asynchronous suspension> #7 Outline.run (file:///usr/local/google/home/jensj/code/dart-sdk/sdk/pkg/front_end/test/fasta/testing/suite.dart:1837:12) <asynchronous suspension> #8 ChainContext.run.doStep.<anonymous closure> (package:testing/src/chain.dart:188:22) <asynchronous suspension> ``` or with assertions enabled: ``` 'package:kernel/ast.dart': Failed assertion: line 1087 pos 14: 'currentClass.implementedTypes.length == 2': is not true. #0 _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:46:39) #1 _AssertionError._throwNew (dart:core-patch/errors_patch.dart:36:5) #2 Class.superclassConstraints (package:kernel/ast.dart:1087:14) #3 ClassBuilderImpl.checkMixinApplication (package:front_end/src/fasta/builder/class_builder.dart:801:51) #4 SourceLoader.checkMixins (package:front_end/src/fasta/source/source_loader.dart:1165:19) #5 KernelTarget.buildOutlines.<anonymous closure> (package:front_end/src/fasta/kernel/kernel_target.dart:339:14) <asynchronous suspension> #6 withCrashReporting (package:front_end/src/fasta/crash.dart:121:12) <asynchronous suspension> #7 Outline.run.<anonymous closure> (file:///usr/local/google/home/jensj/code/dart-sdk/sdk/pkg/front_end/test/fasta/testing/suite.dart:1850:21) <asynchronous suspension> #8 Outline.run (file:///usr/local/google/home/jensj/code/dart-sdk/sdk/pkg/front_end/test/fasta/testing/suite.dart:1837:12) <asynchronous suspension> #9 ChainContext.run.doStep.<anonymous closure> (package:testing/src/chain.dart:188:22) <asynchronous suspension> ``` Bug: #46161 Change-Id: I452729ae4b3d0a14528ea2dda51de14185bb965b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201562 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )