Skip to content

plugin-flow-builder: migrate eslint and prettier to biome#3163

Merged
Iru89 merged 19 commits intomaster-ltsfrom
replace-eslint-and-prettier-for-biome-6
Feb 9, 2026
Merged

plugin-flow-builder: migrate eslint and prettier to biome#3163
Iru89 merged 19 commits intomaster-ltsfrom
replace-eslint-and-prettier-for-biome-6

Conversation

@Iru89
Copy link
Contributor

@Iru89 Iru89 commented Feb 6, 2026

Description

Migrates @botonic/plugin-flow-builder from ESLint + Prettier to Biome v2 as part of the ongoing monorepo linting migration (Phase 1, step 6/6).

  • Replaced ESLint/Prettier scripts with Biome (lint, lint:check, format) and removed eslintConfig from package.json
  • Formatted and auto-fixed 111 files across src/ and tests/ using biome check --write --unsafe
  • Updated pre-commit hook to include botonic-plugin-flow-builder in the Biome pattern and removed the ESLint hook
  • Updated .prettierignore and CI workflow (LINT_COMMAND: npm run lint:check)

Changes breakdown

Configuration files:

  • packages/botonic-plugin-flow-builder/package.json — New lint, lint:check, format scripts using Biome; removed eslintConfig section
  • .pre-commit-config.yaml — Added botonic-plugin-flow-builder to Biome hook pattern; removed dedicated ESLint hook
  • .prettierignore — Added packages/botonic-plugin-flow-builder/
  • .github/workflows/botonic-plugin-flow-builder-tests.yml — Added LINT_COMMAND: npm run lint:check

Source code (auto-fixed by Biome):

  • Converted value imports to import type where only used as types (e.g., import { FlowContent }import type { FlowContent })
  • Removed unused imports (import React from 'react' in 3 files)
  • Renamed unused variables with _ prefix (e.g., catch (error)catch (_error))
  • Wrapped single-line if statements with block statements
  • Applied consistent formatting (single quotes, trailing commas, semicolons, indentation)

Test files:

  • Removed unnecessary @ts-expect-error directives that became unused after import type conversions resolved the underlying type mismatches
  • Applied same formatting fixes as source code

Remaining warnings (acceptable)

These are warnings only and do not block lint:check:

  • noExplicitAny — Existing any types in the codebase (37 warnings)
  • noUselessFragments — Intentional <></> empty returns in JSX (9 infos)
  • noNonNullAssertion — Existing ! assertions

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@Iru89 Iru89 requested review from asastre and vanbasten17 and removed request for asastre February 6, 2026 15:53
@Iru89 Iru89 self-assigned this Feb 6, 2026
@Iru89 Iru89 requested a review from Davidhidalgo February 6, 2026 15:53
@Iru89 Iru89 changed the title plugin-flow-builder: migrate plugin-flow-builder to biome plugin-flow-builder: migrate eslint and prettier to biome Feb 6, 2026
Base automatically changed from replace-eslint-and-prettier-for-biome-5 to master-lts February 9, 2026 09:32
@Iru89 Iru89 merged commit 85e4ae4 into master-lts Feb 9, 2026
2 checks passed
@Iru89 Iru89 deleted the replace-eslint-and-prettier-for-biome-6 branch February 9, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants