Skip to content

Conversation

@mishig25
Copy link
Contributor

@mishig25 mishig25 commented Feb 7, 2022

Add 4 modalities tags (nlp, speech, vision, rl) (technically, I guess, it is 3 modalities + rl) & tag relevant blog posts
(as requested by @patrickvonplaten)

Screenshot 2022-02-07 at 09 41 58

@patrickvonplaten
Copy link
Contributor

Awesome thanks a lot!

mishig25 and others added 2 commits February 7, 2022 15:01
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@julien-c
Copy link
Member

julien-c commented Feb 8, 2022

can we use the same modalities names as in https://github.com/huggingface/huggingface_hub/blob/a217a7e04d4c6785e36fe193ee2576be95815157/js/src/lib/interfaces/Types.ts#L62-L67 for consistency? (and add missing ones there if needed)

More generally let's try to promote naming consistency accross the huggingface platform, going forward :)

@julien-c
Copy link
Member

julien-c commented Apr 2, 2022

do we still want to merge this BTW? 🙏

@mishig25
Copy link
Contributor Author

mishig25 commented Apr 6, 2022

I've added the modalities tags to newer blog posts as well.

can we use the same modalities names as in https://github.com/huggingface/huggingface_hub/blob/a217a7e04d4c6785e36fe193ee2576be95815157/js/src/lib/interfaces/Types.ts#L62-L67 for consistency? (and add missing ones there if needed)

Implemented naming consistency based on below const:

export const MODALITIES = [
	"nlp",
	"audio",
	"cv",
	"other",
] as const;

For reinforcement learning (which does not exist in const MODALITIES), I've chose rl. wdyt @simoninithomas ?

@julien-c
Copy link
Member

julien-c commented Apr 6, 2022

you can maybe add rl to modalities now, or does it not make sense @osanseviero?

@mishig25
Copy link
Contributor Author

mishig25 commented Apr 6, 2022

Here is the hub-docs PR in case we want to add rl to modalities

@osanseviero
Copy link
Contributor

I think you can merge rl_modality to this branch and then merge all into main.

@mishig25 mishig25 merged commit 20ca722 into main Apr 6, 2022
@mishig25 mishig25 deleted the tag_modalities branch April 6, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants