-
Notifications
You must be signed in to change notification settings - Fork 946
Add modalities tag to blog #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Awesome thanks a lot! |
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
osanseviero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
|
can we use the same modalities names as in https://github.com/huggingface/huggingface_hub/blob/a217a7e04d4c6785e36fe193ee2576be95815157/js/src/lib/interfaces/Types.ts#L62-L67 for consistency? (and add missing ones there if needed) More generally let's try to promote naming consistency accross the huggingface platform, going forward :) |
|
do we still want to merge this BTW? 🙏 |
|
I've added the modalities tags to newer blog posts as well.
Implemented naming consistency based on below const: For reinforcement learning (which does not exist in const MODALITIES), I've chose |
|
you can maybe add |
|
Here is the hub-docs PR in case we want to add rl to modalities |
|
I think you can merge rl_modality to this branch and then merge all into main. |
Add 4 modalities tags (
nlp, speech, vision, rl) (technically, I guess, it is 3 modalities + rl) & tag relevant blog posts(as requested by @patrickvonplaten)