Skip to content

Conversation

@mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Apr 6, 2022

Add rl to modalities list

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

Co-authored-by: Omar Sanseviero <osanseviero@gmail.com>
@mishig25 mishig25 merged commit 0434bc0 into main Apr 6, 2022
@mishig25 mishig25 deleted the rl_modality branch April 6, 2022 11:56
@julien-c
Copy link
Member

julien-c commented Apr 6, 2022

maybe we should already add tabular too, @osanseviero ... though it's gonna conflict w/ your other PRs!

@osanseviero
Copy link
Contributor

Let's do it after we finish the task alignment, since we'll get a bunch of tabular tasks

julien-c added a commit that referenced this pull request Apr 12, 2022
julien-c added a commit that referenced this pull request Apr 12, 2022
osanseviero added a commit that referenced this pull request Apr 12, 2022
* Propose new tasks structure

* Remove need for a second list just for the order

* Misc fixes

* Apply suggestions from code review

Co-authored-by: Julien Chaumond <julien@huggingface.co>

* Make data access consistent

* Remove unrelated

* reapply #90

* missing tweak from #90

* reapply #80

* Adopt cool typing solution from @coyotte508

#84 (comment)

* npm run format

* improve typings here now that we have all types?

* Keep same order as in `Types.ts` to minimize diff

* Ooops missing change it seems

* Ok tune down the typing a little bit

* Align subtasks with datasets and add field to hide a task (#86)

* Re-add `PIPELINE_TAGS_DISPLAY_ORDER` to give us freedom on UX side

Co-authored-by: Julien Chaumond <julien@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants