You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The MiniMax H3 model is very popular, congratulations to the MiniMax team.
However, there's currently an issue caused by the Diffusers' team once again modifying the layout of the model for seemingly no reason.
The video VAE's weights are reorganised from [gate, up] to [up, gate].
why? why does this keep happening? what is the actual reason for the swap?
It's caused an enormous amount of time waste to try and make the two weight setups both loadable and function correctly during training and inference.
This isn't the first time it's happened, but it's the first time it's been done in a way that is extremely difficult to track down the issue. Usually, the unnecessary change arises from qkv projections being split when the upstream model release had them fused (and oftentimes their paper eg. Flux.1 and others have mentioned qkv fusion as ultimately required to achieve high levels of hardware utilisation)
Look at the result:
official_fl2va_fixedvae_notile.mp4
It's probably too late to fix it now, just like every other time the Diffusers pipeline has been released without enough time to absorb community feedback. Now we're stuck with two, incompatible sets of weights being distributed for H3 probably forever.
I understand that the tone of this post is going to upset people, but I'm not really worried about it. The time wasted through debugging this issue is worse. It's going to keep affecting people until either the weights are recalled and replaced or another model comes along to replace H3.
Can you simply stop making these changes, especially ones that don't cause obvious errors?
The MiniMax H3 model is very popular, congratulations to the MiniMax team.
However, there's currently an issue caused by the Diffusers' team once again modifying the layout of the model for seemingly no reason.
The video VAE's weights are reorganised from
[gate, up]to[up, gate].why? why does this keep happening? what is the actual reason for the swap?
It's caused an enormous amount of time waste to try and make the two weight setups both loadable and function correctly during training and inference.
This isn't the first time it's happened, but it's the first time it's been done in a way that is extremely difficult to track down the issue. Usually, the unnecessary change arises from qkv projections being split when the upstream model release had them fused (and oftentimes their paper eg. Flux.1 and others have mentioned qkv fusion as ultimately required to achieve high levels of hardware utilisation)
Look at the result:
official_fl2va_fixedvae_notile.mp4
It's probably too late to fix it now, just like every other time the Diffusers pipeline has been released without enough time to absorb community feedback. Now we're stuck with two, incompatible sets of weights being distributed for H3 probably forever.
I understand that the tone of this post is going to upset people, but I'm not really worried about it. The time wasted through debugging this issue is worse. It's going to keep affecting people until either the weights are recalled and replaced or another model comes along to replace H3.
Can you simply stop making these changes, especially ones that don't cause obvious errors?