Skip to content

[core] restrict logging of quant config based on the header size. - #14262

Merged
yiyixuxu merged 2 commits into
mainfrom
fix-20quant-config-logging
Jul 28, 2026
Merged

[core] restrict logging of quant config based on the header size.#14262
yiyixuxu merged 2 commits into
mainfrom
fix-20quant-config-logging

Conversation

@sayakpaul

Copy link
Copy Markdown
Member

Cc: @asomoza does it work?

@github-actions github-actions Bot added models size/S PR with diff < 50 LOC labels Jul 21, 2026
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@asomoza

asomoza commented Jul 21, 2026

Copy link
Copy Markdown
Member

thanks a lot @sayakpaul, yeah this fixes the issue I was having

@sayakpaul
sayakpaul marked this pull request as ready for review July 27, 2026 03:42
@sayakpaul

Copy link
Copy Markdown
Member Author

@DN6 could you review it? This PR unblocks the loading SDNQ checkpoints. Currently, we log the quant config (if user doesn't disable telemetry) in user_agent. We do this for granular comparison on how quant backends are used. For example, is FP8 more used in TorchAO compared to INT8?

However, SDNQ's quant configs can get quite big and can fail the user_agent. Another alternative I considered was the send_telemetry() function from huggingface_hub which is non-blocking. But decided to go with this approach.

@yiyixuxu yiyixuxu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu
yiyixuxu merged commit da3cb57 into main Jul 28, 2026
51 of 54 checks passed
@yiyixuxu
yiyixuxu deleted the fix-20quant-config-logging branch July 28, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

models size/S PR with diff < 50 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants