fix(ldm3d): return uint16/int32 from rgblike_to_depthmap instead of casting back to uint8 - #14424
Open
AloysJehwin wants to merge 1 commit into
Open
fix(ldm3d): return uint16/int32 from rgblike_to_depthmap instead of casting back to uint8#14424AloysJehwin wants to merge 1 commit into
AloysJehwin wants to merge 1 commit into
Conversation
…asting back to uint8 Signed-off-by: Aloys Jehwin <aloysjehwin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14206
rgblike_to_depthmapwas combining two 8-bit channels into a 16-bit value (high * 256 + low), then casting the result back to the inputuint8dtype — truncating it. The numpy path fed that intonumpy_to_depthwhich usesmode="I;16", causingValueError: buffer is not large enough.The fix: return the wider type directly. For numpy,
uint16matches themode="I;16"consumer. For torch,int32preserves the full value.Verified:
rgblike_to_depthmap(high_byte=200, low_byte=100)now returns51300(uint16) instead of truncating to100.