fix(claude): drop --scope from the marketplace remove call - #112
Merged
Conversation
`claude plugin marketplace remove` accepts no --scope flag (only `plugin uninstall` does), so `funes remove claude` aborted with "unknown option '--scope'" after it had already unregistered the MCP server and deleted ~/.funes/integrations/claude-plugin — leaving a marketplace entry pointing at a directory that no longer exists, and no way to reach a clean state without running the CLI by hand. The tests never caught it because the fake CLI accepts any argument list; it only asserts the args funes passes, so the expected log moves with the fix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Claude uninstall/remove flow to stop passing an explicit --scope user to plugin marketplace remove, and aligns the expected command log output accordingly.
Changes:
- Removed
--scope userfrom theclaude plugin marketplace removecommand arguments. - Updated the user-facing removal instructions string to match the unscoped marketplace remove command.
- Updated the
tests/remove.rsexpected output to match the new command sequence.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/remove.rs | Updates the expected logged command output for the remove flow. |
| src/claude.rs | Removes the --scope user argument from marketplace removal and updates instruction text accordingly. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+131
to
132
| &["plugin", "marketplace", "remove", "huggingface"], | ||
| &["Marketplace 'huggingface' not found"], |
Comment on lines
108
to
+110
| " claude mcp remove funes -s user\n \ | ||
| claude plugin uninstall funes@huggingface -s user\n \ | ||
| claude plugin marketplace remove huggingface --scope user" | ||
| claude plugin marketplace remove huggingface" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
claude plugin marketplace removeaccepts no --scope flag (onlyplugin uninstalldoes), sofunes remove claudeaborted with "unknown option '--scope'" after it had already unregistered the MCP server and deleted ~/.funes/integrations/claude-plugin — leaving a marketplace entry pointing at a directory that no longer exists, and no way to reach a clean state without running the CLI by hand.The tests never caught it because the fake CLI accepts any argument list; it only asserts the args funes passes, so the expected log moves with the fix.