Simplify integration and add demo gifs#60
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude and opencode still defaulted to a per-project config (`--global` to opt out); like the earlier pi change, that scope is untested and invites the same duplicate-registration conflicts. Drop `--global` from both and remove the cwd-relative branches, so `funes add <agent>` is always user-wide. No agent can write a project-local config anymore. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR simplifies “add agent” integrations by removing project-scoped install options (standardizing on user-scope installs), and updates documentation with new demo GIFs and revised automation guidance.
Changes:
- Remove project-scope / destination options for agent integrations (Claude, Pi, OpenCode) and standardize installs on user scope.
- Add and reference new demo GIFs, plus new VHS tape sources for regenerating them.
- Rework automation docs to split indexing vs publishing hooks (per-turn indexing + session-boundary publishing).
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pi.rs | Makes funes add pi install to a fixed user-wide location and always pi install it. |
| src/opencode.rs | Makes funes add opencode always write user config (no project-scope). |
| src/main.rs | Simplifies CLI subcommand variants by removing --global/--dest options. |
| src/claude.rs | Makes funes add claude always register at user scope. |
| skills/funes/SKILL.md | Removes the optional skill documentation file. |
| README.md | Adds demo GIFs and adjusts “get started” instructions/snippets. |
| docs/demo/hub-store.tape | Adds VHS tape for the “Hub store” demo GIF. |
| docs/demo/cross-agents.tape | Adds VHS tape for the “cross agents” demo GIF. |
| docs/automation.md | Updates hook guidance and adds split scripts for index vs push. |
Comments suppressed due to low confidence (1)
docs/automation.md:127
find_binis used asfunes="$(find_bin funes ...)", but thecommand -v ... && return 0branch returns success without printing the resolved path, so$funesbecomes empty even whenfunesis on PATH.
find_bin() {
command -v "$1" 2>/dev/null && return 0
for d in "$HOME/.local/bin" /opt/homebrew/bin /usr/local/bin "$HOME/go/bin" /usr/bin /bin; do
[ -x "$d/$1" ] && { printf '%s\n' "$d/$1"; return 0; }
done
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
46
to
49
| ```bash | ||
| curl -fsSL https://huggingface.co/buckets/huggingface/funes/resolve/funes-x86_64-linux -o funes | ||
| chmod +x funes && ./funes recall "how do I get started with funes" | ||
| chmod +x funes | ||
| ``` |
The `fmt --check` CI step (cargo +nightly-2026-04-22) flagged the pi install-success line as over max_width; wrap the macro call as rustfmt would. No behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- README: the by-hand download block chmod'd the binary but never showed how to run it (it lands at ./funes, not on PATH); restore the `./funes recall` step so the manual path isn't a dead end. - hub-store.tape: scope the comment to the store — FUNES_HOME redirects the demo store, not the pi extension (which installs globally to ~/.funes/integrations/pi), so "nothing lands in ~/.funes" was imprecise. The other two Copilot comments (claude.rs .context, automation.md find_bin) are false positives; no change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the options to add funes to an agent just for a project.
This also adds two demo gifs to the README.