kernel-builder: upload README to version branch as well - #791
Merged
Conversation
sayakpaul
reviewed
Aug 27, 2026
| collect_readme_commit_ops(temp_dir.path(), &BTreeSet::new(), &mut operations); | ||
| assert!(operations.is_empty()); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Shouldn't we also test if the card is uploaded to the provided version as well?
This makes it more testable.
This was a really weird case where the user did not specify a branch, there was no branch in `build.toml` and the branch could not be discovered from metadata. In that case we would only upload `README.md` to the main branch (which would then possibly be out-of-sync)? In such such a case, bail out with an error instead.
sayakpaul
approved these changes
Aug 27, 2026
sayakpaul
left a comment
sayakpaul
left a comment
Member
There was a problem hiding this comment.
Very nice and thanks for iterating!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.