Skip to content

feat: suggest compatible variants when available in newer versions - #817

Merged
sayakpaul merged 3 commits into
mainfrom
improve-version-suggestion
Sep 4, 2026
Merged

feat: suggest compatible variants when available in newer versions#817
sayakpaul merged 3 commits into
mainfrom
improve-version-suggestion

Conversation

@sayakpaul

Copy link
Copy Markdown
Member

Fixes #744

Comment thread kernels/src/kernels/resolver.py Outdated
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

from pathlib import Path

import pytest
from huggingface_hub.hf_api import GitRefInfo

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have covered most bases here but I have a feeling I am missing 1/2 tests.

@sayakpaul
sayakpaul marked this pull request as ready for review September 4, 2026 10:53
Comment thread kernels/src/kernels/resolver.py Outdated
Comment thread kernels/src/kernels/resolver.py Outdated
Comment thread kernels/src/kernels/resolver.py Outdated
Comment thread kernels/src/kernels/resolver.py Outdated
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Coverage report — kernels/

Measured on: Python 3.10 / Torch 2.13.0.
Other CI configurations are not included in this number.
Hardware-gated code paths (ROCm/XPU/NPU/Darwin/Windows) are excluded or unreachable on the Linux+CUDA runner.

Total coverage: 87.1% — threshold: 80% — ✅

Per-file breakdown
Name Stmts Miss Cover Missing
src/kernels/__init__.py 14 0 100%
src/kernels/_system.py 6 1 83% 10
src/kernels/_versions.py 78 9 88% 47, 53-54, 57-58, 97, 119, 130, 136
src/kernels/archs.py 56 1 98% 95
src/kernels/backends.py 213 62 71% 42, 46, 50-53, 70, 92, 110, 119, 123, 127-129, 150, 159, 163, 167-169, 190, 201, 203, 210-213, 226, 230, 234-254, 262, 285-305
src/kernels/compat.py 8 1 88% 5
src/kernels/deps.py 65 1 98% 58
src/kernels/hf_hub.py 63 2 97% 20, 22
src/kernels/importer.py 44 5 89% 83, 87, 90, 104-105
src/kernels/install.py 21 7 67% 77-101
src/kernels/layer/__init__.py 6 0 100%
src/kernels/layer/_interval_tree.py 103 4 96% 23, 52, 147, 150
src/kernels/layer/device.py 48 14 71% 42, 47-49, 91, 96-98, 101, 149, 152, 155-157
src/kernels/layer/func.py 88 6 93% 92, 125, 198, 318, 344, 374
src/kernels/layer/globals.py 5 0 100%
src/kernels/layer/kernelize.py 80 8 90% 258, 293, 301-302, 308, 312, 328-330
src/kernels/layer/layer.py 218 14 94% 189, 236, 262, 396, 476-477, 498, 506, 517, 546, 550, 563, 616, 646
src/kernels/layer/mode.py 14 0 100%
src/kernels/layer/repos.py 144 42 71% 27, 33, 36-43, 63-64, 70, 73-76, 90, 94, 103-104, 110, 113-116, 123-124, 130, 133-136, 143-144, 150, 153-156, 163-164, 170, 173-176, 257
src/kernels/load.py 70 2 97% 329, 368
src/kernels/locking.py 89 64 28% 35-83, 91-98, 102-125, 137, 152-159, 165-175, 179-186
src/kernels/python_deps.py 58 6 90% 59-60, 64-65, 101, 104
src/kernels/resolver.py 156 2 99% 220, 226
src/kernels/status.py 50 2 96% 25, 79
src/kernels/validate.py 54 1 98% 85
src/kernels/variants.py 278 19 93% 65, 96, 117, 147, 256-257, 299-302, 304, 388-394, 400-406, 437-443, 455-461
src/kernels/verify.py 88 1 99% 32
TOTAL 2117 274 87%

Updated by the Test kernels workflow on commit 14d36ffaeeb355b61fada8147d38b135dde4e169.

@danieldk danieldk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great UX improvement!

@sayakpaul
sayakpaul merged commit 73ae242 into main Sep 4, 2026
53 of 54 checks passed
@sayakpaul
sayakpaul deleted the improve-version-suggestion branch September 4, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggest newer kernel version in error when no compatible variant exists for current version

3 participants