Method comparison: Small optimizations to image-gen - #3523
Open
BenjaminBossan wants to merge 1 commit into
Open
Conversation
1. Don't recalculate step indices We already have them, it was an unnecessary calculation. I did a double check that the indices are indeed the same. 2. Detach loss before logging Avoids small memory leak due to retaining graph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have them, it was an unnecessary calculation. I did a double check that the indices are indeed the same.
Avoids small memory leak due to retaining graph.
I ran a test with default LoRA and both losses and runtime were unaffected, so I think there is no need to re-run all experiments when this is merged.