[megatron_gpt2] dynamic gelu, add tokenizer, save config#13928
Merged
stas00 merged 4 commits intohuggingface:masterfrom Oct 26, 2021
Merged
[megatron_gpt2] dynamic gelu, add tokenizer, save config#13928stas00 merged 4 commits intohuggingface:masterfrom
stas00 merged 4 commits intohuggingface:masterfrom
Conversation
sgugger
approved these changes
Oct 25, 2021
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Looks good, thanks for adding those improvements!
src/transformers/models/megatron_gpt2/convert_megatron_gpt2_checkpoint.py
Outdated
Show resolved
Hide resolved
src/transformers/models/megatron_gpt2/convert_megatron_gpt2_checkpoint.py
Outdated
Show resolved
Hide resolved
src/transformers/models/megatron_gpt2/convert_megatron_gpt2_checkpoint.py
Outdated
Show resolved
Hide resolved
…eckpoint.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
LysandreJik
approved these changes
Oct 26, 2021
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
This looks good, thank you @stas00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves
megatron_gpt2/convert_megatron_gpt2_checkpoint.py:config.tokenizer_classconfig.save_pretrainedto ensure the config gets the right bits of the most recenttransformersSome of this functionality has been discussed here #13906