Skip to content

Raise exceptions instead of asserts in src/transformers/data/processors/utils.py#13938

Merged
sgugger merged 1 commit intohuggingface:masterfrom
killazz67:utils_replace_assert_with_exceptions
Oct 11, 2021
Merged

Raise exceptions instead of asserts in src/transformers/data/processors/utils.py#13938
sgugger merged 1 commit intohuggingface:masterfrom
killazz67:utils_replace_assert_with_exceptions

Conversation

@killazz67
Copy link
Copy Markdown
Contributor

@killazz67 killazz67 commented Oct 8, 2021

What does this PR do?

Related to #12789.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Copy Markdown
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@patil-suraj patil-suraj requested a review from sgugger October 11, 2021 16:10
Copy link
Copy Markdown
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing those!

@sgugger sgugger merged commit 64743d0 into huggingface:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants