Replace assert by ValueError of src/transformers/models/electra/modeling_{electra,tf_electra}.py and all other models that had copies#13955
Merged
sgugger merged 16 commits intohuggingface:masterfrom Oct 11, 2021
Conversation
AkechiShiro
force-pushed
the
replace-assert-models-modeling-electra-by-exception
branch
from
f183373 to
3860118
Compare
AkechiShiro
force-pushed
the
replace-assert-models-modeling-electra-by-exception
branch
from
7c726b3 to
a6fc239
Compare
* Change multiples models assertion to ValueError in order to validate check_code_style test and models template test.
… in code_style_check
AkechiShiro
changed the title
AkechiShiro
changed the title
sgugger
approved these changes
Oct 11, 2021
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Thanks a lot for fixing those, added a few comments :-)
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
…rt.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Contributor
Author
|
Thank you for your suggestion about the ValueError message and the simplification made to the logic to improve readability, I think this PR is ready to merge. |
Collaborator
|
Thanks a lot for adapting! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to issue: #12789
I've had to change others files in order that the code_check_quality tests passes, if there is any change that should be removed please feel free to let me know.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
I'm tagging @LysandreJik because I have modified the albert and bert models as well as other that had to be changed in order for the
code_quality_checkto pass.