Skip to content

BartEnocder add set_input_embeddings#13960

Merged
patrickvonplaten merged 2 commits intohuggingface:masterfrom
Liangtaiwan:bart_encoder_set_embed
Oct 25, 2021
Merged

BartEnocder add set_input_embeddings#13960
patrickvonplaten merged 2 commits intohuggingface:masterfrom
Liangtaiwan:bart_encoder_set_embed

Conversation

@Liangtaiwan
Copy link
Copy Markdown
Contributor

@Liangtaiwan Liangtaiwan commented Oct 11, 2021

What does this PR do?

To unify the interface of the seq2seq models (eg. T5, Bart....), I add set_input_embeddings, get_input_embeddings to BartEncoder.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@patrickvonplaten, @patil-suraj

To unify the interface, add set_input_embeddings to BartEncoder.
@patrickvonplaten patrickvonplaten merged commit 1967c43 into huggingface:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants