Don't duplicate the elements in dir#14023
Merged
LysandreJik merged 1 commit intomasterfrom Oct 16, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There is a tiny bug in the way the
__dir__method of our lazy modules is implemented. To see it run:which will give a list ending with
You can already see some elements are duplicated, and accessing some other submodules (like the modeling ones) will grow the list of duplicates.
This comes because we always add all the submodules to the
__dir__even if they are already there (the fact they are there or not depends on whether some element of the submodule was accessed to, because of the lazy init).This PR fixes that.
Thanks to @NielsRogge for reporting the bug!