Skip to content

Fix: replace assert statements with exceptions in file src/transformers/models/lxmert/modeling_lxmert.py#14029

Merged
sgugger merged 1 commit intohuggingface:masterfrom
murilo-goncalves:fix/replace-assert-with-exception
Oct 15, 2021
Merged

Fix: replace assert statements with exceptions in file src/transformers/models/lxmert/modeling_lxmert.py#14029
sgugger merged 1 commit intohuggingface:masterfrom
murilo-goncalves:fix/replace-assert-with-exception

Conversation

@murilo-goncalves
Copy link
Copy Markdown
Contributor

@murilo-goncalves murilo-goncalves commented Oct 15, 2021

What does this PR do?

Replaced assert statements with ValueError exceptions in file src/transformers/models/lxmert/modeling_lxmert.py,
as discussed in issue #12789

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sgugger

@murilo-goncalves murilo-goncalves changed the title Fix: replace assert statements with exception in file src/transformers/models/lxmert/modeling_lxmert.py Fix: replace assert statements with exceptions in file src/transformers/models/lxmert/modeling_lxmert.py Oct 15, 2021
Copy link
Copy Markdown
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@sgugger sgugger merged commit 47489a6 into huggingface:master Oct 15, 2021
@murilo-goncalves murilo-goncalves deleted the fix/replace-assert-with-exception branch October 19, 2021 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants