[Speech] Move all examples to new audio feature#14045
Merged
patrickvonplaten merged 4 commits intohuggingface:masterfrom Oct 18, 2021
Merged
[Speech] Move all examples to new audio feature#14045patrickvonplaten merged 4 commits intohuggingface:masterfrom
patrickvonplaten merged 4 commits intohuggingface:masterfrom
Conversation
anton-l
approved these changes
Oct 18, 2021
LysandreJik
approved these changes
Oct 18, 2021
Member
LysandreJik
left a comment
There was a problem hiding this comment.
Great, very clean to leverage the new datasets audio integration! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes sure that audio loading uses the new audio feature in all tests. At the same time the dataset
"hf-internal-testing/librispeech_asr_dummy"is updated to make use of the new audio feature.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.