Skip to content

[Speech] Move all examples to new audio feature#14045

Merged
patrickvonplaten merged 4 commits intohuggingface:masterfrom
patrickvonplaten:correct_all_speech_examples
Oct 18, 2021
Merged

[Speech] Move all examples to new audio feature#14045
patrickvonplaten merged 4 commits intohuggingface:masterfrom
patrickvonplaten:correct_all_speech_examples

Conversation

@patrickvonplaten
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR makes sure that audio loading uses the new audio feature in all tests. At the same time the dataset "hf-internal-testing/librispeech_asr_dummy" is updated to make use of the new audio feature.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Copy Markdown
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, very clean to leverage the new datasets audio integration! LGTM

@patrickvonplaten patrickvonplaten merged commit bdf31d6 into huggingface:master Oct 18, 2021
@patrickvonplaten patrickvonplaten deleted the correct_all_speech_examples branch October 18, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants