Skip to content

Add missing autocast() in Trainer.prediction_step()#14075

Merged
sgugger merged 1 commit intohuggingface:masterfrom
juice500ml:bugfix/fp16_eval
Oct 20, 2021
Merged

Add missing autocast() in Trainer.prediction_step()#14075
sgugger merged 1 commit intohuggingface:masterfrom
juice500ml:bugfix/fp16_eval

Conversation

@juice500ml
Copy link
Copy Markdown
Contributor

What does this PR do?

On prediction_step() where has_labels == True and self.use_amp == True, it does not use autocast() in calling self.compute_loss, which triggers RuntimeError: Input type (torch.cuda.FloatTensor) and weight type (torch.cuda.HalfTensor) should be the same. This commit fixes the issue.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@sgugger
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Copy Markdown
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@sgugger sgugger merged commit 0106826 into huggingface:master Oct 20, 2021
@juice500ml juice500ml deleted the bugfix/fp16_eval branch October 21, 2021 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants