Skip to content

Change asserts in src/transformers/models/xlnet/ to raise ValueError#14088

Merged
sgugger merged 2 commits intohuggingface:masterfrom
westonkl:fix-asserts-in-transformers-xlnet-model
Oct 21, 2021
Merged

Change asserts in src/transformers/models/xlnet/ to raise ValueError#14088
sgugger merged 2 commits intohuggingface:masterfrom
westonkl:fix-asserts-in-transformers-xlnet-model

Conversation

@westonkl
Copy link
Copy Markdown
Contributor

What does this PR do?

Replaces asserts in:
src/transformers/models/xlnet/configuration_xlnet.py and src/transformers/models/xlnet/modeling_tf_xlnet.py
to a ValueError exception.

Contributes towards fixing issue #12789

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@sgugger

Copy link
Copy Markdown
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help!

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
@sgugger sgugger merged commit 9e4ea25 into huggingface:master Oct 21, 2021
@westonkl westonkl deleted the fix-asserts-in-transformers-xlnet-model branch October 21, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants