Skip to content

integrations: mlflow: skip start_run() if a run is already active and sanity check on enabling integration #16131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2022
Merged

integrations: mlflow: skip start_run() if a run is already active and sanity check on enabling integration #16131

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a969bc
integrations: mlflow: skip start_run() call if a run is already active
ktzsh Mar 14, 2022
d9e1d93
integrations: typo fix
ktzsh Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/transformers/integrations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ def is_azureml_available():


def is_mlflow_available():
if os.getenv("DISABLE_MLFLOW_INTEGRATION", "FALSE").upper() == "TRUE":
return False
return importlib.util.find_spec("mlflow") is not None


Expand Down Expand Up @@ -758,7 +760,8 @@ def on_log(self, args, state, control, logs=None, **kwargs):

class MLflowCallback(TrainerCallback):
"""
A [`TrainerCallback`] that sends the logs to [MLflow](https://www.mlflow.org/).
A [`TrainerCallback`] that sends the logs to [MLflow](https://www.mlflow.org/). Can be disabled by setting
environment variable `DISABLE_MLFLOW_INTEGRATION = TRUE`.
"""

def __init__(self):
Expand Down Expand Up @@ -789,7 +792,8 @@ def setup(self, args, state, model):
if log_artifacts in {"TRUE", "1"}:
self._log_artifacts = True
if state.is_world_process_zero:
self._ml_flow.start_run(run_name=args.run_name)
if self._ml_flow.active_run is None:
self._ml_flow.start_run(run_name=args.run_name)
combined_dict = args.to_dict()
if hasattr(model, "config") and model.config is not None:
model_config = model.config.to_dict()
Expand Down