Skip to content

added type hints to yoso #16163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2022
Merged

added type hints to yoso #16163

merged 1 commit into from
Mar 15, 2022

Conversation

@mowafess
Copy link
Contributor

@mowafess mowafess commented Mar 15, 2022 •
edited
Loading

What does this PR do?

I added type annotations for YOSO PyTorch as described in #16059

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Rocketknight1 @gante @sgugger

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 15, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@mowafess
Copy link
Contributor Author

mowafess commented Mar 15, 2022 •
edited
Loading

@Rocketknight1
Kindly help review

@Rocketknight1 Rocketknight1 self-assigned this Mar 15, 2022
Rocketknight1
Rocketknight1 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me, thank you for the PR!

@Rocketknight1 Rocketknight1 merged commit 4a353ca into huggingface:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rocketknight1 Rocketknight1 Rocketknight1 approved these changes

Assignees

@Rocketknight1 Rocketknight1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mowafess @HuggingFaceDocBuilderDev @Rocketknight1