Update modeling_cvt.py type hints#17846
Merged
Rocketknight1 merged 1 commit intohuggingface:mainfrom Jun 23, 2022
Merged
Conversation
As shown in the colab notebook I added the missing type hints for " CvtForImageClassification CvtModel "
|
The documentation is not available anymore as the PR was closed or merged. |
Rocketknight1
approved these changes
Jun 23, 2022
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
This looks great, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As shown in the colab notebook I added the missing type hints for " CvtForImageClassification
CvtModel
"
What does this PR do?
Add missing type hints for CTV pytorch. #16059 following this Colab notebook
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@Rocketknight1