Move logic into pixelshuffle layer#17899
Merged
amyeroberts merged 3 commits intohuggingface:mainfrom Jun 28, 2022
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Rocketknight1
approved these changes
Jun 28, 2022
Comment on lines
+1245
to
+1248
| permutation = tf.constant( | ||
| [[i + j * block_size_squared for i in range(block_size_squared) for j in range(output_depth)]] | ||
| ) | ||
| hidden_states = tf.gather(params=hidden_states, indices=tf.tile(permutation, [batch_size, 1]), batch_dims=-1) |
Member
There was a problem hiding this comment.
Any appearance of gather in this kind of context is a 100% guarantee that someone is emulating the specific details of a weird Torch function.
viclzhu
pushed a commit
to viclzhu/transformers
that referenced
this pull request
Jul 18, 2022
* Move all pixelshuffle logic into layer * Rename layer * Use correct input to function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves logic relating to PixelShuffle layer into layer class. This is to provide a consistent usage wrt the PyTorch pixel shuffle layer and makes sure all necessary logic is ported if any
#Copied fromstatements are used.Also renamed layer
PixelShuffle->TFSwinPixelShuffleto reflect naming in the rest of the repo. The following was run to make sure the models are still compatible with current weights:With the following output. Note:
relative_position_indexisn't updated during training and is set as an instance param in the TF modelBefore submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.