Skip to content

Make MobileBert tokenizers independent from Bert#19531

Merged
sgugger merged 5 commits intohuggingface:mainfrom
501Good:independent-mobilebert-tokenizer
Oct 12, 2022
Merged

Make MobileBert tokenizers independent from Bert#19531
sgugger merged 5 commits intohuggingface:mainfrom
501Good:independent-mobilebert-tokenizer

Conversation

@501Good
Copy link
Contributor

@501Good 501Good commented Oct 12, 2022

What does this PR do?

Copied the code from Bert tokenizers into MobileBert tokenizers to make the latter self-contained.

Fixes #19303

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@sgugger

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last nit and we will be good to merge! Thanks a lot!

501Good and others added 2 commits October 12, 2022 17:10
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
501Good and others added 2 commits October 12, 2022 17:12
@sgugger sgugger merged commit 4edb3e4 into huggingface:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make all models folder independent from each other

2 participants