Skip to content

Conversation

@amyeroberts
Copy link
Contributor

What does this PR do?

  • Adds logic to add-new-model-like CLI to include image processors
  • Updates tests/utils/add_new_model_like.py so tests run (was outdated)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 24, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the tests and adding support for this!

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @amyeroberts for working on this.

Just wondering, is the CI test_add_new_model_like.py currently broken? I can't see it from other PRs. Otherwise, are the changes necessary for your PR to pass this CI?

@sgugger
Copy link
Collaborator

sgugger commented Nov 28, 2022

@ydshieh The test requires all three frameworks (PyTorch, TensorFlow and Flax) so it is never run in the CI.

@ydshieh
Copy link
Collaborator

ydshieh commented Nov 28, 2022

OK, I completely misunderstand Add model like runner / Add new model like template tests (pull_request).
Ignore my previous comment 🙏 .

@amyeroberts amyeroberts merged commit 321ef38 into huggingface:main Nov 28, 2022
@amyeroberts amyeroberts deleted the add-model-like-image-processor branch November 28, 2022 16:46
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants