Skip to content

Fixed typo in docstring#21115

Merged
sgugger merged 1 commit intohuggingface:mainfrom
tkburis:patch-1
Jan 15, 2023
Merged

Fixed typo in docstring#21115
sgugger merged 1 commit intohuggingface:mainfrom
tkburis:patch-1

Conversation

@tkburis
Copy link
Copy Markdown
Contributor

@tkburis tkburis commented Jan 13, 2023

What does this PR do?

Missing 'to' in 'pad the inputs the maximum length'.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Jan 13, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Copy Markdown
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! cc @sgugger

Copy link
Copy Markdown
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Can you just run make style on your branch to fix the quality issue?

@tkburis
Copy link
Copy Markdown
Contributor Author

tkburis commented Jan 14, 2023

Hi @sgugger,

I've looked at the CircleCI test and it seems like it failed because of a timeout when installing from PIP, not because of styling. Is there any way to rerun the tests?

@sgugger sgugger merged commit 5db9abd into huggingface:main Jan 15, 2023
@sgugger
Copy link
Copy Markdown
Collaborator

sgugger commented Jan 15, 2023

Indeed, everything is green on re-launch. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants