[pipeline] Add pool option to image feature extraction pipeline#28985
Merged
amyeroberts merged 2 commits intohuggingface:mainfrom Feb 20, 2024
Merged
[pipeline] Add pool option to image feature extraction pipeline#28985amyeroberts merged 2 commits intohuggingface:mainfrom
pipeline] Add pool option to image feature extraction pipeline#28985amyeroberts merged 2 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Feb 20, 2024
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
LGTM, let's maybe add a pipeline test were we make sure the outputs slices are alright (instead of juste the shape?)
|
|
||
| if pool: | ||
| if "pooler_output" not in model_outputs: | ||
| raise ValueError("The model needs to have a `pooler` layer to use the `pool` option.") |
Collaborator
There was a problem hiding this comment.
it more like the pooler_outpus were not returned since we don't check if there is a pooler layer layer or not 😉
Contributor
Author
|
@ArthurZucker Updated the error message and added tests for exact outputs in b94d08c |
ArthurZucker
approved these changes
Feb 20, 2024
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Nice! Feel free to merge 🤗
37563a5 to
33378e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the flag
poolwhich will return the pooled output, rather than the raw hidden states.Doesn't work for data2vecvision as the model doesn't add the pooling layer by default. At the moment, model kwargs aren't passed to the model constructor, so it's not simple to add passing
add_pooling_layerhere.I chose to raise an error when getting the outputs of the model. Although this means we fail quite late, it avoids any complex inspection needed on the model.
From the list of models in #28944:
Models which work with the
pooloption:Models that don't have a pooling layer:
Not working
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.