Avoid dummy token in PLD to optimize performance#29445
Merged
gante merged 1 commit intohuggingface:mainfrom Mar 6, 2024
Merged
Avoid dummy token in PLD to optimize performance#29445gante merged 1 commit intohuggingface:mainfrom
gante merged 1 commit intohuggingface:mainfrom
Conversation
ArthurZucker
approved these changes
Mar 6, 2024
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Looks good thanks for following up on this
Contributor
Author
|
@gante I am unable to share my measurements since I am working on HW that wasn't released yet. Is it blocking the merge? |
Contributor
|
@ofirzaf no :) I'm going to merge the PR In any case, if you have the script to reproduce your measurements, it would be a nice addition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Current PLD implementation adds a dummy token in case there is no match found in the prompt to avoid issues. In previous PR #28508 the code was fixed to handle zero candidate tokens so there is no need for the dummy token in PLD now. Not inserting this additional token can accelerate PDL on weaker HW where doing inference with the target with 2 tokens is significantly slower than doing inference with 1 token.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
@gante