Conversation
ArthurZucker
commented
Apr 1, 2024
| f"Tried to split a class or function. It did not work. Error comes from line {start_index}: ```\n" | ||
| + "".join(lines[start_index:end_index]) | ||
| f"Tried to split a class or function. It did not work. Error comes from line {start_index}: \n```\n" | ||
| + "".join(lines[start_context:end_context]) |
Collaborator
Author
There was a problem hiding this comment.
just adding some context can help a lot!
| @pytest.mark.flash_attn_test | ||
| @slow | ||
| def test_flash_attn_2_inference_padding_right(self): | ||
| def test_flash_attn_2_inference_equivalence_right_padding(self): |
ArthurZucker
commented
Apr 1, 2024
gante
approved these changes
Apr 1, 2024
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
Thank you for the fix 🙏 (Extra context is great!)
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
reviewed
Apr 2, 2024
| observed_obj_name = re_pattern.search(observed_code_header).groups()[0] | ||
| except Exception: | ||
| raise ValueError( | ||
| "Tried to split a class or function. It did not work. Error comes from: \n```\n" |
Collaborator
There was a problem hiding this comment.
The error message is a bit confusing here. The re_pattern is used to extract the class or function name, not to split the blocks (unlike the above one)
Collaborator
Author
There was a problem hiding this comment.
feel free to update it. 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After #29909