Resolve automatic label name detection when single label provided#40438
Open
ndonthi wants to merge 4 commits intohuggingface:mainfrom
Open
Resolve automatic label name detection when single label provided#40438ndonthi wants to merge 4 commits intohuggingface:mainfrom
ndonthi wants to merge 4 commits intohuggingface:mainfrom
Conversation
Member
|
cc @SunMarc |
Author
|
checking in on this! @SunMarc @Rocketknight1 let me know if there's another preferred solution :) |
SunMarc
reviewed
Dec 29, 2025
Member
SunMarc
left a comment
There was a problem hiding this comment.
Thanks for digging ! Sorry for the late review, I missed the notification ... Can you add a test also ? One question I have is how did you get the error in the issue ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Users frequently encounter a confusing KeyError when setting label_names=['label'] in TrainingArguments, leading to errors like:
The label_names parameter is designed for advanced multi-label scenarios, but users often mistakenly use label_names=['label'] thinking they need to specify their label column. This breaks the automatic "label" → "labels" conversion that happens during data collation which causes loss calculation to fail silently.
This PR introduces validation for this edge case and fixes the issue in the Trainer to use automatic label detection. If it's preferred, I can make this change where the automatic label detection happens as well!
Implements a code fix to #28530 #40217 and #32373 on huggingface forum
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
with @
@zach-huggingface, @muellerzr @adrienchaton