Update torch minimum version to 2.4#41307
Conversation
|
I'm not sure we automatically bump the Torch version with new releases like we do with Python! cc @ydshieh @Cyrilvallez, is that a policy? |
|
Humm no indeed, we don't have something like "we support last 5 versions". Bumps are usually not correlated with a new version, but for other internal technical reasons |
|
There is a (not-written) convention about : if a torch version is released 2 years ago, we will drop it. |
|
But torch 2.2 is out Jan 30, 2024, not yet fully 2 years old. |
|
The PyTorch release time is not quite regular. I recall that 2.8.0 had taken half a year. IMO a two year policy is good.. |
|
@cyyever PyTorch does a release approximately every quarter now. Given #41960 this may make sense even though 2.2 isn't at two years yet. There's overlap on this with #42135. @Rocketknight1 wdyt? |
|
OK for me |
|
Actually, there are other instances of that functions without protection. They should use our internal |
|
cc @cyyever this got lost (my bad), and now it's time to bump to 2.4 instead of 2.3! Would you be okay with updating the version number here and then I can approve and merge it? If not I can make a separate PR |
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
|
@Rocketknight1 More updates |
|
Okay, now we just need to fix our own CI 😅 |
Signed-off-by: cyy <cyyever@outlook.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Rocketknight1
left a comment
There was a problem hiding this comment.
CI is passing now, and thanks for the comprehensive cleanup of version checks that we don't need anymore!
|
well okay one test is failing, hold on 🫠 |
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
|
@Rocketknight1 It is green |
|
@cyyever there was another merge conflict today - if I can get it green again after that I'll merge! |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: albert, bert, clvp, deepseek_v3, depth_anything, diffllama, esm, falcon, gpt_neo, gptj, kyutai_speech_to_text, mimi, moshi, nemotron |
What does this PR do?
PyTorch 2.10 has been released. Looking forward to lift the PT minimum version again.