Add skip_unnecessary_grad_clip to TrainingArguments for optimized gradient clipping#41491
Open
vaibhavgarg230 wants to merge 2 commits intohuggingface:mainfrom
Open
Add skip_unnecessary_grad_clip to TrainingArguments for optimized gradient clipping#41491vaibhavgarg230 wants to merge 2 commits intohuggingface:mainfrom
vaibhavgarg230 wants to merge 2 commits intohuggingface:mainfrom
Conversation
Author
|
Hey @zach-huggingface, @SunMarc ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds an opt-in
skip_unnecessary_grad_clipargument toTrainingArguments, optimizing Trainer’s gradient clipping for better efficiency. When enabled, the Trainer computes and logs the gradient norm every step, but skips callingclip_grad_norm_if the norm is already belowmax_grad_norm. This prevents unnecessary computation for models/trainers with consistently low gradient norms, while always maintaining logging.Maintainer requests addressed:
Falseby default).Motivation:
Dependencies:
Tests added:
tests/trainer/test_gradient_clipping.pyDocumentation:
Before submitting
Who can review?
Thanks for reviewing! Feedback and suggestions are very welcome.