Remove some custom datasets defined in codebase #41511
Conversation
There was a problem hiding this comment.
I want to remove this example script under legacy and not to handle the removed classes ...
I would love to remove the whole legacy directory as it is mentioned
# Legacy examples
This folder contains examples which are not actively maintained (mostly contributed by the community).
Using these examples together with a recent version of the library usually requires to make small (sometimes big) adaptations to get the scripts working.
May I ? 🙏
There was a problem hiding this comment.
cc @ArthurZucker here as well, but in my opinion it's fine to delete the folder. Everything is very old, so they are not useful examples anyway
There was a problem hiding this comment.
This says, in 2020
DEPRECATION_WARNING = (
"This dataset will be removed from the library soon, preprocessing should be handled with the 🤗 Datasets "
"library. You can have a look at this example script for pointers: {0}"
)
There was a problem hiding this comment.
I need to rework on 6 tests, not done yet
|
@Cyrilvallez If you could make the call or discuss with the other core maintainers 🙏 regarding if I can remove the file |
ydshieh
changed the title
|
[don't merge yet] |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
LGTM :) add it to the v5 issue
ydshieh
force-pushed
the
remove_datasets
branch
from
a57ca60 to
eb3199b
Compare
ydshieh
changed the title
|
OK merge now. eb3199b should be fine, but will address if there are comments provided later . |
|
Merge ! The failing test
is flaky!!! |
* how bad it woud be anyway? * let's break all * delete * update --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
What does this PR do?
It should have been gone long long time ago ...