-
Notifications
You must be signed in to change notification settings - Fork 31.3k
🚨 Refactor DETR to updated standards #41549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yonigozlan
wants to merge
10
commits into
huggingface:main
Choose a base branch
from
yonigozlan:refactor-detr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
18e7172
refactor attention and many other
yonigozlan a931c26
Merge remote-tracking branch 'upstream/main' into refactor-detr
yonigozlan f7536b9
remove return_dict interface
yonigozlan c016021
improve variable names
yonigozlan 7f21985
use _can_record_outputs and add real support for pixel and queries ma…
yonigozlan d0494e9
split self attention and cross attention
yonigozlan 2f0752f
nits
yonigozlan 67a007a
standardize mask handling
yonigozlan eab4e85
update DetrMHAttentionMap
yonigozlan ac8d387
refactor mlp detr
yonigozlan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -206,6 +206,7 @@ def is_local_dist_rank_0(): | |
| "qwen2_5_vl", | ||
| "videollava", | ||
| "vipllava", | ||
| "detr", | ||
| ] | ||
|
|
||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, do we need to add this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's what made me go crazy haha otherwise
_checkpoint_conversion_mappingdoesn't work.Note that this is temporary and will be replaced by the new way to convert weights on the fly that @ArthurZucker and @Cyrilvallez are working on.