Skip to content

Correct type hint in config models#41980

Open
jorisSchaller wants to merge 1 commit intohuggingface:mainfrom
jorisSchaller:feat/type_hint
Open

Correct type hint in config models#41980
jorisSchaller wants to merge 1 commit intohuggingface:mainfrom
jorisSchaller:feat/type_hint

Conversation

@jorisSchaller
Copy link
Copy Markdown

What does this PR do?

Most models are using a config with rms_norm_eps: Optional[int] = 1e-6: I modified it to an optional float.
This update configs that use a type of optional int instead of optional float for the epsilon value for their RMS norm.
You can clearly see that the epsilon has a default value of 10e-6 (float), the hint should therefore be adjusted.

FIx no issue.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

Who can review?

Let me know if you want any changes, @ArthurZucker @Cyrilvallez @stevhliu, I tried to find all occurence of it, but some might have slipped through.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 2, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: deepseek_v2, deepseek_v3, dots1, gemma, gemma2, gemma3, granite, granitemoe, granitemoehybrid, granitemoeshared, jetmoe, llama, mistral, qwen2, qwen2_5_omni, qwen2_moe

@Rocketknight1
Copy link
Copy Markdown
Member

Looks good but please run make fix-copies to propagate modular changes! Ping me again whenever the CI is green and I'll merge it

…ms norm config

Signed-off-by: jorisSchaller <71265553+jorisSchaller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants