Update test_dynamic_cache_exportability_multiple_run (failing on torch 2.10 nightly)
#42212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
changed the title
test_dynamic_cache_exportability_multiple_run (failing on torch 2.10 nightly)
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
vasqu
approved these changes
Nov 14, 2025
Contributor
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
LGTM, my only concern is that we should check for BC (not sure when that way of calling .DYNAMIC is supported)
Collaborator
Author
|
it's a test, so i won't worry the BC :-) |
Contributor
|
gotcha, fine by me then :p |
CrazyDubya
pushed a commit
to CrazyDubya/transformers
that referenced
this pull request
Nov 18, 2025
…rch 2.10 nightly) (huggingface#42212) Implement TODOs: Better error handling and warnings (batch 3) Implemented several TODO items for better error handling: 1. serve.py: Add proper validation when force_model is set - Now raises ValueError if request specifies different model than forced - Clear error message guiding users on how to fix 2. image_utils.py: Convert validate_kwargs logging to proper warning - Changed from logger.warning() to warnings.warn() - Uses UserWarning with proper stacklevel for better debugging Impact: - Better error messages for users - Proper warning handling instead of logging - Removes 2 TODO items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See
pytorch/pytorch#167293 (comment)
The suggestion seems to reasonable since the test name is