Skip to content

Conversation

@Yacklin
Copy link
Contributor

@Yacklin Yacklin commented Nov 25, 2025

What does this PR do?

It fixes Json syntax error for example zero2 json configuration file.

(I accidentatlly closed a PR related to it so i have to make another PR)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc @MekkCyber @Rocketknight1

Copy link
Contributor

@MekkCyber MekkCyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Yacklin
Copy link
Contributor Author

Yacklin commented Nov 26, 2025

i need someone to approve lol

@Rocketknight1
Copy link
Member

Merging!

@Rocketknight1 Rocketknight1 merged commit 96c41be into huggingface:main Nov 26, 2025
14 checks passed
@Yacklin Yacklin deleted the fixed-json-syntax-error-for-zero2-found-in-deepspeed-markdown branch November 26, 2025 14:35
@Yacklin
Copy link
Contributor Author

Yacklin commented Nov 26, 2025

Merging!

my GOAT!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants