Skip to content

remove ipex and ccl for xpu and cpu#42852

Merged
ArthurZucker merged 31 commits intohuggingface:mainfrom
yao-matrix:remove-ipex
Feb 3, 2026
Merged

remove ipex and ccl for xpu and cpu#42852
ArthurZucker merged 31 commits intohuggingface:mainfrom
yao-matrix:remove-ipex

Conversation

@yao-matrix
Copy link
Contributor

remove ipex and ccl for xpu and cpu, since all ipex optimizations are upstreamed to PyTorch or kernels-community; ccl for xpu is upstreamed to PyTorch built-in xccl backend; ccl for cpu will use gloo

upstreamed to PyTorch or kernels-community; ccl for xpu is upstreamed to
PyTorch built-in xccl backend; ccl for cpu will use gloo

Signed-off-by: Yao, Matrix <matrix.yao@intel.com>
Signed-off-by: Yao, Matrix <matrix.yao@intel.com>
Signed-off-by: Yao, Matrix <matrix.yao@intel.com>
Signed-off-by: Yao, Matrix <matrix.yao@intel.com>
Signed-off-by: Yao, Matrix <matrix.yao@intel.com>
Signed-off-by: Yao, Matrix <matrix.yao@intel.com>
Signed-off-by: Matrix YAO <matrix.yao@intel.com>
Signed-off-by: Matrix YAO <matrix.yao@intel.com>
@yao-matrix
Copy link
Contributor Author

@jiqing-feng , pls help review, thx.

@yao-matrix yao-matrix marked this pull request as draft December 17, 2025 23:39
@jiqing-feng
Copy link
Contributor

LGTM.

@yao-matrix
Copy link
Contributor Author

pending on auto-round issue intel/auto-round#1154 to make the auto-round case pass.

@yao-matrix yao-matrix marked this pull request as ready for review January 16, 2026 17:04
@yao-matrix
Copy link
Contributor Author

@SunMarc , pls help review, this is to fully remove ccl-backend and ipex from transformers, as planed.

@github-actions
Copy link
Contributor

View the CircleCI Test Summary for this PR:

https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=42852&sha=3eac2a

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up ! Just a small nit

output = quantized_model.generate(**input_ids, max_new_tokens=40, do_sample=False)
self.assertIn(self.tokenizer.decode(output[0], skip_special_tokens=True), self.EXPECTED_OUTPUTS)

@require_intel_extension_for_pytorch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can skip those tests or require a specific tag to be enabled ? It will be too slow on our CI to run the model on our cpu.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SunMarc, done, thx

inputs = tokenizer(text, return_tensors="pt").to(model.device)
tokenizer.decode(model.generate(**inputs, max_new_tokens=5)[0])

@require_intel_extension_for_pytorch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Matrix YAO <matrix.yao@intel.com>
Signed-off-by: Matrix YAO <matrix.yao@intel.com>
@yao-matrix
Copy link
Contributor Author

the CI failure is not brought by this PR

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@SunMarc SunMarc enabled auto-merge (squash) January 30, 2026 14:15
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

[For maintainers] Suggested jobs to run (before merge)

run-slow: autoround, gptq

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ( I seem to understand its here starting 2.4 and we are droping / dropped 2.3)

@ArthurZucker ArthurZucker disabled auto-merge February 3, 2026 09:40
@ArthurZucker ArthurZucker merged commit 683c3e9 into huggingface:main Feb 3, 2026
22 of 25 checks passed
@yao-matrix yao-matrix deleted the remove-ipex branch February 3, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants