Make EoMT visible to type checkers#42967
Merged
Merged
Conversation
molbap
reviewed
Dec 22, 2025
Contributor
molbap
left a comment
There was a problem hiding this comment.
Hey @simonreise , thanks for the PR! It seems that a couple models are missing in the init, grepping those in src/models that are not in the init yields
eomt
ernie4_5_vl_moe
jais2
kosmos2_5
metaclip_2
mm_grounding_dino
pe_audio
pe_audio_video
pe_video
sam3
sam3_videodo you mind adding them as well? They might have exclusions from custom rule but AFAIK they should also be included in the models init.
molbap
approved these changes
Dec 22, 2025
Contributor
molbap
left a comment
There was a problem hiding this comment.
Thanks for your contribution! core maintainers will review and see for merge
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sniper35
pushed a commit
to sniper35/transformers
that referenced
this pull request
Jan 5, 2026
* Make EoMT visible to type checkers * Add more models
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
* Make EoMT visible to type checkers * Add more models
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
EoMT is not listed in
if TYPE_CHECKINGblock ofmodels.__init__.py. It did not cause any errors, but made type checker angryBefore submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@yonigozlan @molbap