Skip to content

Make EoMT visible to type checkers#42967

Merged
ArthurZucker merged 3 commits into
huggingface:mainfrom
simonreise:eomt-type-checking
Jan 5, 2026
Merged

Make EoMT visible to type checkers#42967
ArthurZucker merged 3 commits into
huggingface:mainfrom
simonreise:eomt-type-checking

Conversation

@simonreise
Copy link
Copy Markdown
Contributor

What does this PR do?

EoMT is not listed in if TYPE_CHECKING block of models.__init__.py. It did not cause any errors, but made type checker angry

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@yonigozlan @molbap

Copy link
Copy Markdown
Contributor

@molbap molbap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @simonreise , thanks for the PR! It seems that a couple models are missing in the init, grepping those in src/models that are not in the init yields

 eomt
 ernie4_5_vl_moe
 jais2
 kosmos2_5
 metaclip_2
 mm_grounding_dino
 pe_audio
 pe_audio_video
 pe_video
 sam3
 sam3_video

do you mind adding them as well? They might have exclusions from custom rule but AFAIK they should also be included in the models init.

@molbap molbap requested review from LysandreJik and molbap December 22, 2025 19:07
Copy link
Copy Markdown
Contributor

@molbap molbap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! core maintainers will review and see for merge

Copy link
Copy Markdown
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ArthurZucker ArthurZucker merged commit b383753 into huggingface:main Jan 5, 2026
25 checks passed
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

sniper35 pushed a commit to sniper35/transformers that referenced this pull request Jan 5, 2026
* Make EoMT visible to type checkers

* Add more models
SangbumChoi pushed a commit to SangbumChoi/transformers that referenced this pull request Jan 23, 2026
* Make EoMT visible to type checkers

* Add more models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants