Skip to content

Replace config.get() with getattr(config)#43321

Merged
ArthurZucker merged 1 commit intomainfrom
fix_config_get
Jan 16, 2026
Merged

Replace config.get() with getattr(config)#43321
ArthurZucker merged 1 commit intomainfrom
fix_config_get

Conversation

@Rocketknight1
Copy link
Copy Markdown
Member

A buggy line was introduced in #42894 that uses config.get(), but config classes are not dicts and don't have item access like that. Replaced it with getattr()!

Fixes #43272, cc @ArthurZucker for review

@Rocketknight1 Rocketknight1 marked this pull request as ready for review January 16, 2026 13:00
@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: auto

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions
Copy link
Copy Markdown
Contributor

View the CircleCI Test Summary for this PR:

https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=43321&sha=781ff5

Copy link
Copy Markdown
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@ArthurZucker ArthurZucker merged commit 7d05b60 into main Jan 16, 2026
24 of 26 checks passed
@ArthurZucker ArthurZucker deleted the fix_config_get branch January 16, 2026 15:04
SangbumChoi pushed a commit to SangbumChoi/transformers that referenced this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants