Fix tiles mixing for batched input, add tie_word_embeddings to LFM2VL config#43379
Merged
zucchini-nlp merged 4 commits intohuggingface:mainfrom Jan 28, 2026
Merged
Fix tiles mixing for batched input, add tie_word_embeddings to LFM2VL config#43379zucchini-nlp merged 4 commits intohuggingface:mainfrom
zucchini-nlp merged 4 commits intohuggingface:mainfrom
Conversation
1 task
zucchini-nlp
approved these changes
Jan 26, 2026
Member
zucchini-nlp
left a comment
zucchini-nlp
left a comment
There was a problem hiding this comment.
Thanks, I will trigger slow tests and check
Member
|
run-slow: lfm2_vl |
Contributor
|
This comment contains models: ["models/lfm2_vl"] |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
CI Results✅ No failing test specific to this PR 🎉 ! |
Member
|
I can't push to this branch apparently, can you update the docstring @ankke and add |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: lfm2_vl |
Member
|
run-slow: lfm2_vl |
Contributor
|
This comment contains models: ["models/lfm2_vl"] |
Contributor
CI Results✅ No failing test specific to this PR 🎉 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: For batched input with multiple images tiled input was mixed between batches.Now, using a util function.
Adds:
tie_word_embeddingsto Lfm2VlConfig. Tests for above bug + updated integration test for the newest lfm2vl model.cc: @zucchini-nlp