Skip to content

[HunYuan] Fix RoPE init#43411

Merged
vasqu merged 4 commits intomainfrom
fix-huan-rope-init
Feb 2, 2026
Merged

[HunYuan] Fix RoPE init#43411
vasqu merged 4 commits intomainfrom
fix-huan-rope-init

Conversation

@vasqu
Copy link
Contributor

@vasqu vasqu commented Jan 22, 2026

As per title, currently init weights assumes everything is uniform but these dynamic inits are slightly different

@vasqu
Copy link
Contributor Author

vasqu commented Jan 22, 2026

cc @xenova if you could check if it works for you, just made a quick draft for this as we talked internally about this models series

@vasqu vasqu changed the title [HunYuan] Fix RoPE init [HunYuan] Fix RoPE init Jan 22, 2026
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@xenova xenova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this PR fixes the bug I encountered! 🙌

@vasqu vasqu marked this pull request as ready for review January 23, 2026 10:43
@vasqu
Copy link
Contributor Author

vasqu commented Jan 23, 2026

run-slow: hunyuan_v1_dense, hunyuan_v1_moe

@github-actions
Copy link
Contributor

💔 This comment contains run-slow, but unknown error occurred and the workflow run aborted!

@vasqu
Copy link
Contributor Author

vasqu commented Jan 23, 2026

run-slow: hunyuan_v1_dense, hunyuan_v1_moe

@github-actions
Copy link
Contributor

This comment contains run-slow, running the specified jobs:

models: ["models/hunyuan_v1_dense", "models/hunyuan_v1_moe"]
quantizations: []

@github-actions
Copy link
Contributor

CI Results

Workflow Run ⚙️

✅ No failing test specific to this PR 🎉 !

Copy link
Contributor

@xenova xenova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me (on the test case that caused this discussion)!

@vasqu vasqu mentioned this pull request Jan 26, 2026
5 tasks
@vasqu
Copy link
Contributor Author

vasqu commented Jan 27, 2026

run-slow: hunyuan_v1_moe

@github-actions
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: hunyuan_v1_dense, hunyuan_v1_moe

@github-actions
Copy link
Contributor

This comment contains run-slow, running the specified jobs:

models: ["models/hunyuan_v1_moe"]
quantizations: []

@github-actions
Copy link
Contributor

CI Results

Workflow Run ⚙️

✅ No failing test specific to this PR 🎉 !

@vasqu vasqu merged commit 4cd791d into main Feb 2, 2026
21 checks passed
@vasqu vasqu deleted the fix-huan-rope-init branch February 2, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants