benchmark-v2: minor fix for benchmark-v2, kernel is not correctly called#43428
Merged
remi-or merged 8 commits intohuggingface:mainfrom Jan 31, 2026
Merged
benchmark-v2: minor fix for benchmark-v2, kernel is not correctly called#43428remi-or merged 8 commits intohuggingface:mainfrom
remi-or merged 8 commits intohuggingface:mainfrom
Conversation
Signed-off-by: Wang, Yi <yi.a.wang@intel.com>
Contributor
Author
|
@remi-or , pls help review, thx very much. |
Signed-off-by: Wang, Yi <yi.a.wang@intel.com>
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=43428&sha=0c40fd |
remi-or
reviewed
Jan 26, 2026
Collaborator
remi-or
left a comment
remi-or
left a comment
There was a problem hiding this comment.
Thanks for the contribution! A few nits to address but otherwise we should be good.
Signed-off-by: Wang, Yi <yi.a.wang@intel.com>
remi-or
approved these changes
Jan 29, 2026
Collaborator
remi-or
left a comment
remi-or
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution and the insights!
Signed-off-by: Wang, Yi <yi.a.wang@intel.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
@SunMarc , could you help merge it? Thx very much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kernels is not correctly called in benchmark_v2, should register before kernelize, see
transformers/src/transformers/modeling_utils.py
Line 3607 in 10e97cd