RagTokenizer: add encode and patch_token(_id) forwarding#43468
Closed
sherlock-488 wants to merge 2 commits intohuggingface:mainfrom
Closed
RagTokenizer: add encode and patch_token(_id) forwarding#43468sherlock-488 wants to merge 2 commits intohuggingface:mainfrom
sherlock-488 wants to merge 2 commits intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: rag |
Author
|
Hi! This PR implements encode() and patch_token/patch_token_id forwarding for RagTokenizer, with a lightweight regression test (no model downloads). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35532
What does this PR do?
encode()toRagTokenizerby forwarding tocurrent_tokenizer.patch_token/patch_token_idgetters and setters, also forwarding tocurrent_tokenizer.Why?
RagTokenizerforwards__call__()viacurrent_tokenizerbut lacks common tokenizer APIs likeencode()andpatch_token(_id),which can break preprocessing code expecting a standard tokenizer interface.
Tests