Fix extras on all supported Python versions#43490
Fix extras on all supported Python versions#43490tarekziade merged 51 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Cyrilvallez
left a comment
There was a problem hiding this comment.
Very nice idea in general!
I assume it's because those lib versions are not compatible with the python version above the conditional? In some cases, would probably make more sense to have the full extra in the conditional, instead of some of the deps!
yes correct, recent Python versions are not well supported yet for all wheels/platform, in some projects |
|
Supersed by @Cyrilvallez work on e46d21a |
fd045a2 to
e82eb25
Compare
There was a problem hiding this comment.
i will let you play with this first.
we can talk about some aspects in more details in person
ydshieh
left a comment
There was a problem hiding this comment.
Nice, just a few remaining nit comments
Cyrilvallez
left a comment
There was a problem hiding this comment.
Very very nice! Thanks a lot!
I think we simply need to fix the python version on which we want to run the update of dependency table!
Co-authored-by: Cyril Vallez <cyril.vallez@gmail.com>
Cyrilvallez
left a comment
There was a problem hiding this comment.
Perfect thanks for making the changes!
|
|
||
| - name: Aggregate failures | ||
| run: | | ||
| python utils/aggregate_failure_reports.py \ |
There was a problem hiding this comment.
ok. just a remark : I tend to (since one year) not create new script files unless it will be used in several workflow files. But it's fine, I will explain why on Monday.
What does this PR do?
It makes sure
extrascan be installed on all supported Python versions.pip installworks on all extras