Skip to content

Fix extras on all supported Python versions#43490

Merged
tarekziade merged 51 commits intohuggingface:mainfrom
tarekziade:tarekziade-fix-extras
Jan 30, 2026
Merged

Fix extras on all supported Python versions#43490
tarekziade merged 51 commits intohuggingface:mainfrom
tarekziade:tarekziade-fix-extras

Conversation

@tarekziade
Copy link
Collaborator

@tarekziade tarekziade commented Jan 26, 2026

What does this PR do?

It makes sure extras can be installed on all supported Python versions.

  • cleaned up extras (removed natten, tweaked mistral-common etc,)
  • adds a supported Python version range (10->14)
  • dynamically update the metadata
  • run a smoke test in the CI every night to verify pip install works on all extras

@tarekziade tarekziade requested review from vasqu and ydshieh January 26, 2026 10:28
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@Cyrilvallez Cyrilvallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice idea in general!
I assume it's because those lib versions are not compatible with the python version above the conditional? In some cases, would probably make more sense to have the full extra in the conditional, instead of some of the deps!

@tarekziade
Copy link
Collaborator Author

Very nice idea in general! I assume it's because those lib versions are not compatible with the python version above the conditional? In some cases, would probably make more sense to have the full extra in the conditional, instead of some of the deps!

yes correct, recent Python versions are not well supported yet for all wheels/platform, in some projects

@tarekziade
Copy link
Collaborator Author

Supersed by @Cyrilvallez work on e46d21a

@tarekziade tarekziade closed this Jan 29, 2026
@tarekziade tarekziade deleted the tarekziade-fix-extras branch January 29, 2026 08:54
@tarekziade tarekziade restored the tarekziade-fix-extras branch January 29, 2026 09:23
@tarekziade tarekziade reopened this Jan 29, 2026
@tarekziade tarekziade force-pushed the tarekziade-fix-extras branch 2 times, most recently from fd045a2 to e82eb25 Compare January 29, 2026 12:19
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will let you play with this first.

we can talk about some aspects in more details in person

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just a few remaining nit comments

Copy link
Member

@Cyrilvallez Cyrilvallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very nice! Thanks a lot!
I think we simply need to fix the python version on which we want to run the update of dependency table!

Copy link
Member

@Cyrilvallez Cyrilvallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks for making the changes!

@tarekziade tarekziade enabled auto-merge (squash) January 30, 2026 14:10

- name: Aggregate failures
run: |
python utils/aggregate_failure_reports.py \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. just a remark : I tend to (since one year) not create new script files unless it will be used in several workflow files. But it's fine, I will explain why on Monday.

@tarekziade tarekziade merged commit 797c822 into huggingface:main Jan 30, 2026
25 checks passed
@tarekziade tarekziade deleted the tarekziade-fix-extras branch January 30, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants