Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Feb 2, 2026
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
this makes the code a bit more stateful, but it might be better. I am mostly thinking of multi-gpu runs, this should make stuff simpler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors all of the logic linked to the inputs and outputs of continuous batching into a new class
ContinuousBatchingIOsitself in a new file. This will be quite useful when we introduce async scheduling, because there will be two sets of host-side IOs and one set of device-side IOs.To avoid having this major refactoring AND the async logic in the same PR, I think it would be good if we can first merge this part, which does not change much, and then add the async logic.
This PR also makes the test file
tycompatible and adds a bit more documentation.