Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR sets
HF_HUB_DOWNLOAD_TIMEOUT=60as environment variable when running tests. I've also addedpytest-envas a dev dependency to do that.I've also reverted #43560 which is not needed anymore.
Note: there might still be some
ReadTimeouts in CI when running scripts that are not run withpytest. I preferred not to touch that part as I don't have a broad understanding on what the CI does but any failing workflow (due to timeouts) should be fixable with aHF_HUB_DOWNLOAD_TIMEOUT=60env variable.Note 2: this PR requires huggingface_hub v1.3.5 to work. I don't think we should pin this version as minimal dependency though, since it's just to fix some tests. In theory the CI will always pull the latest version so it should be fine.